Home Forums sipX-dev about 4.4 reverted patch

 TOPIC

about 4.4 reverted patch

2
2
524
Last Post:   Jul 4,2012 at 12:00 AM
 
 
RSS
  • July 2, 2012 at 12:00 am  
    Comment  
    I know that some latest patch are been reverted from 4.4 trunk.
    I was curious to know if this part of a reverted patch can be
    considered still valid for sipXtackLib:
    
    
    674             -         if ((res == 2 &&
    675             -              readBuffer(0) == 'r' && readBuffer(1) ==
    'n')
    ||
    676             -             (res == 4 &&
    677             -              readBuffer(0) == 'r' && readBuffer(1) == 'n'
    &&
    678             -              readBuffer(2) == 'r' && readBuffer(3) ==
    'n'))
             675    +         //
             676    +         // Count the CRLF sequence and see if the entire
    buffer is composed of it
             677    +         //
             678    +         int crlfCount = 0;
             679    +         for (int i = 0; i < res; i+=2)
             680    +         {
             681    +           if (readBuffer(i) == 'r' && readBuffer(i) ==
    'n')
             682    +             crlfCount+=2;
             683    +           else
             684    +             break;
             685    +         }
             686    +
             687    +         if (crlfCount == res)
    679      688              {
    
    thanks
    Domenico Chierico
    
  • July 3, 2012 at 12:00 am  
    Comment  

    George Niculae George Niculae
    Senior Expert
    Posts: 1579
    On Tue, Jul 3, 2012 at 1:24 AM, Domenico Chierico
    <domenico.chierico@xxxxxxxxxx> wrote:
    > I know that some latest patch are been reverted from 4.4 trunk.
    > I was curious to know if this part of a reverted patch can be
    > considered still valid for sipXtackLib:
    >
    
    I think we should apply and test the patch separately then merge it in
    release-4.4 if you see improvements. There is also that problem you
    noticed and needs to be corrected (readBuffer(i+1))
    
    George
    
  • July 4, 2012 at 12:00 am  
    Comment  
    I've just checked about this on our production system. We got the same error:
    
    2012-07-04T01:32:07.184579Z":20021:SIP:ERR:opsip.sip2ser.it:SipClientUdp-12:58A4
    4700:SipXProxy:"Url::parseString
    no valid host found at char 0 in ';tag=0s9Jiv', uriForm = name-addr"
    "2012-07-04T01:32:07.184691Z":20022:SIP:WARNING:opsip.sip2ser.it:SipClientU
    dp-12:58A44700:SipXProxy:"SipMessage::getResponseSendAddress
    No VIA address, using From address"
    "2012-07-04T01:32:07.184729Z":20023:SIP:ERR:opsip.sip2ser.it:SipClientUdp-1
    2:58A44700:SipXProxy:"SipMessage::convertProtocolStringToEnum
    unrecognized protocol:"
    "2012-07-04T01:32:07.184738Z":20024:SIP:ERR:opsip.sip2ser.it:SipClientUdp-1
    2:58A44700:SipXProxy:"SipTransaction::doFirstSend
    protocol not explicitly set - using UDP"
    "2012-07-04T01:32:17.199452Z":20025:SIP:ERR:opsip.sip2ser.it:SipClientUdp-1
    2:58A44700:SipXProxy:"Url::parseString
    no valid host found at char 0 in ';tag=e8ApjL', uriForm = name-addr"
    
    in this days I will generate new rpm with the patch than I will let
    you know about
    
    On Tue, Jul 3, 2012 at 7:11 AM, George Niculae <george@xxxxxxxxx> wrote:
    > On Tue, Jul 3, 2012 at 1:24 AM, Domenico Chierico
    > <domenico.chierico@xxxxxxxxxx> wrote:
    >> I know that some latest patch are been reverted from 4.4 trunk.
    >> I was curious to know if this part of a reverted patch can be
    >> considered still valid for sipXtackLib:
    >>
    >
    > I think we should apply and test the patch separately then merge it in
    > release-4.4 if you see improvements. There is also that problem you
    > noticed and needs to be corrected (readBuffer(i+1))
    >
    > George
    > _______________________________________________
    > sipx-dev mailing list
    > sipx-dev@xxxxxxxxxxxxxxxxxxx
    > List Archive: http://list.sipfoundry.org/archive/sipx-dev/
    
REPLY